Say-Their-Name / say-their-names-web

Open-source platform that raises awareness of the injustice and often forgotten names of racial inequality.
https://saytheirnames.io/
MIT License
56 stars 30 forks source link

Updating Footer #121

Closed jsundai closed 4 years ago

jsundai commented 4 years ago

What does this PR do?

Note - Having an issue with the UI and aligning the text. I replaced the original svg for twitter in my local code to make the design work. Can use this code as a base for further changes to match the Figma design.

Description of Task to be completed?

How should this be manually tested?

What are the relevant Trello Card stories? Trello Card Item

Pull Request Type (check one)

Developer Checklist

Screenshots (if appropriate)

jsundai commented 4 years ago

@iamcristos Quick question? Where did you get the svg for the Twitter icon? I've been trying to align text with the original svg to follow the Figma design. However, it would probably be easier to follow the original Twitter svg design which already has the text aligned to the icon. I'd like to duplicate this for Instagram and Facebook. Thank you!

iamcristos commented 4 years ago

@iamcristos Quick question? Where did you get the SVG for the Twitter icon? I've been trying to align text with the original SVG to follow the Figma design. However, it would probably be easier to follow the original Twitter SVG design which already has the text aligned to the icon. I'd like to duplicate this for Instagram and Facebook. @jsundai I go the SVG from the Figma file that was shared... on Figma click on the icon and export... remember to change the file type to SVG

jsundai commented 4 years ago

@iamcristos Thank you! That makes complete sense. I'm definitely making things harder than it needs to be. I will update everything.