Chore: Unit test Donations, PetitionDetail, Petitions and ProfileDetail - Githubissues

Say-Their-Name / say-their-names-web

Open-source platform that raises awareness of the injustice and often forgotten names of racial inequality.

https://saytheirnames.io/

MIT License

56 stars 28 forks source link

Chore: Unit test Donations, PetitionDetail, Petitions and ProfileDetail #122

Closed krisgardiner closed 4 years ago

krisgardiner commented 4 years ago

What does this PR do?

Adds last set of unit tests for pages

Description of Task to be completed?

Unit test for Donations, PetitionDetail, Petitions, ProfileDetail
NotFound messages have been moved outside of the main return, if actual errors occur when fetching data, the page will break due to TypeError

How should this be manually tested?

yarn test
throw an error after axios.get on pages and it won't fail gracefully.

What are the relevant Trello Card stories? Trello Card Item

https://trello.com/c/WSHTMjJU/94-initial-unit-tests

Pull Request Type (check one)

[ ] Feature
[x] Bug Fixes
[x] Chore

Developer Checklist

[x] New code has been scanned for ESlint issues
[x] I have tested my code locally
[x] I made sure that there are no other pull requests that solve for this issue
[x] My code follows the same structure within the guidelines

Screenshots (if appropriate)