Fix social media sharing

Say-Their-Name / say-their-names-web

Open-source platform that raises awareness of the injustice and often forgotten names of racial inequality.

https://saytheirnames.io/

MIT License

56 stars 30 forks source link

Fix social media sharing #125

Closed lantelyes closed 4 years ago

lantelyes commented 4 years ago

What does this PR do?

Updates the sharing copy for twitter

Description of Task to be completed?

Fix the hashtag copy error when sharing via twitter on donation and pension pages

How should this be manually tested?

Go to the various donation/pension pages and click the twitter share button

What are the relevant Trello Card stories? [ Trello Card Item (https://trello.com/c/SIhNL5av/108-fix-sharing-hashtag-bug)

Pull Request Type (check one)

[ ] Feature
[x] Bug Fixes
[ ] Chore

Developer Checklist

[x] New code has been scanned for ESlint issues
[ ] I have tested my code locally ( See note below )
[x] I made sure that there are no other pull requests that solve for this issue
[x] My code follows the same structure within the guidelines

Note: This is WIP, there seems to be no data for movements and protestors in the donation page, and policies in the pension page. So I have not been able to test those

Easybuoy commented 4 years ago

Tested, and it only works for Twitter, is there any plan for doing for the other social media platforms? @lantelyes

lantelyes commented 4 years ago

I can add copy to the other platforms as well, should it be the same as the copy as twitter?

Easybuoy commented 4 years ago

I can add copy to the other platforms as well, should it be the same as the copy for twitter?

Yes, It should be

Easybuoy commented 4 years ago

Also noticed the profile detail sharing hasn't been done yet as well

Easybuoy commented 4 years ago

Good job, it looked great on Twitter

lantelyes commented 4 years ago

Thanks! And thanks for the clarification. I'll update the other social platforms with this copy, and complete the profile detail sharing.

I just stepped out, but will be back in an hour or so and get this in right away

lantelyes commented 4 years ago

@Easybuoy I've updated all the links to use the same copy, and added the copy to the profile details page (I used the same copy as for victim donations)

Easybuoy commented 4 years ago

Have you been able to test this? https://github.com/Say-Their-Name/say-their-names-web/issues/62#issuecomment-641431288

Easybuoy commented 4 years ago

@Easybuoy I've updated all the links to use the same copy, and added the copy to the profile details page (I used the same copy as for victim donations)

Looks good

ashleygraf101 commented 4 years ago

Whatsapp doesn't have hashtags, but it could be a good visual point of interest in group chats.

lantelyes commented 4 years ago

Have you been able to test this? #62 (comment)

Not yet, @devingray I still don't see the data in the database, could you make sure it was published?

lantelyes commented 4 years ago

I just made some copy suggestions. Code looks good!

Good suggestions! made the changes

Easybuoy commented 4 years ago

I asked Devin, he said he's pushed the changes, but if there're still issues he'd fix tomorrow. You can reach out to him on slack if they're still issues

Easybuoy commented 4 years ago

I think we should merge this, we'd fix any other issue that comes up in another pull request.

This is MVP critical