search

Sayani07 / gghdr

Plots of highest density regions (HDR) for ggplot2
https://sayani07.github.io/gghdr/
GNU General Public License v3.0
47 stars 5 forks source link

Guide compatability with ggplot2 >=3.5.0 #25

Open teunbrand opened 1 year ago

teunbrand commented 1 year ago

Hello Sayani,

Apologies for the cold PR without posting an issue first. The ggplot2 package has changed the implementation of the guide system, which means that the old S3 system will no longer work, see ggplot2's news file.

This PR aims to update the guide_prob methods so that it is compatible with the development version of ggplot2. It is still a work in progress (WIP) as I'm doing an inventory of S3 guides to preserve them.

Best, Teun

teunbrand commented 10 months ago

This PR is now ready for review, though there were some warnings that appeared unrelated to this PR.

teunbrand commented 5 months ago

This is a reminder that the release of the ggplot2 version that contains changes to the guide system is scheduled soon.

benjaminhlina commented 2 months ago

This would be great to implement as I'm working on trying to implement hdr plots that are used in this vignette to represent niche regions produced by the package {SIBER}. I'd love to make these plots in ggplot instead of base and this package looks great but seems to no longer work considering the changes to ggplot. Seems like this PR would fix that...thoughts? @Sayani07 and @mitchelloharawild

teunbrand commented 2 months ago

@benjaminhlina As far as I can tell, this package hasn't seen any updates for the past 2 years along with a sparse github activity over the same period from the maintainer. Because this issue wasn't resolved in time, the package has also been archived on CRAN.

Per the README, the package indicates it is part of an @rOpenSci project, so it might be best to ask them what the future of this package might look like. If that user handle doesn't trigger any notification, I'd like to loop in @maelle whose name I know from social media and might be able to redirect this to the attention of the appropriate person. (Apologies for the noise!)

benjaminhlina commented 2 months ago

Thanks for providing some info on the current status of the package and who to reach out to about the status of this package. appreciate the work you've put into trying to update and maintain the package.

mitchelloharawild commented 2 months ago

I can take over as maintainer for this and get it back on CRAN, but the long term future of the package is probably merging with ggdist and using the hdr class from distributional.

maelle commented 2 months ago

:wave: @teunbrand! You were right to ping me as @ropensci will not notify anyone. Anyhow, this package was created during an rOpenSci unconference and was then transferred to the personal account of an author (#18), it is not part of the rOpenSci suite of packages.

I see @mitchelloharawild responded, thanks!

maelle commented 2 months ago

@mitchelloharawild it might make sense to remove the rOpenSci footer from the README. :smile_cat:

mitchelloharawild commented 2 months ago

Agreed regarding the footer, either @Sayani07 can fix the package and remove it, or transfer the repository and I'll take over as maintainer. Package maintainer discussions can/will continue in #22.