search

Sayani07 / gghdr

Plots of highest density regions (HDR) for ggplot2
https://sayani07.github.io/gghdr/
GNU General Public License v3.0
47 stars 5 forks source link

vdiffr visual regression tests not working #7

Closed Ryo-N7 closed 2 years ago

Ryo-N7 commented 4 years ago

possibly due to: https://github.com/r-lib/vdiffr/issues/36

Sayani07 commented 4 years ago

Any brainstorming on this would be helpful. Some of the plot components depend on random variation which might lead to this problem as suggested here. The calc.falpha argument used in HDRs do use sampling. Maybe adding an seed here might help. Any suggestions?

mitchelloharawild commented 2 years ago

Closing as tests now seem fine. Presumably adding the seed fixed this issue.