Saylua-Archive / SayluaLegacy

Browser Game In Development
saylua.com
GNU Affero General Public License v3.0
2 stars 0 forks source link

SQLAlchemy migrations, provisioning #71

Closed NoiSek closed 7 years ago

NoiSek commented 7 years ago

Didn't intend to, but ended up partially fulfilling #45 on accident instead of actually doing any forum administration features.

Migrates the User, BankAccount, DisplayName, LoginSession, Role, Board, BoardCategory, ForumThread and ForumPost models to SQLAlchemy.

Also adds slight provisioning rework + forum provisioning.

Notes:

Registration and login are currently functional. Notifications / Messages, the actual post submission on Forums, and much of the rest of the site are currently non-functional as a side-effect of the partial model migration. (Maybe it's a good idea to keep Notifications / Messages on NDB if they will always be 1:1?)

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 0.0% when pulling 2d7bc1ac49987dddbfee4f4448febd2fab6f77a6 on forum_administration into deba3c997e94345b0b0896266f7ca9c26cf4f763 on master.

tiffz commented 7 years ago

Man, I'm impressed by how quickly you did so much. Thanks for the good work and the writeup. I will write a quick response here before I dive in more into the code.

I think we will probably want to eventually convert Messages and Notifications to ndb as well for these reasons:

Though these conversions are certainly not urgent if we can get away with delaying them and have things still function.

As a side note, I would be open to potentially using a hybrid of ndb and SQL in the future if the site is up and running, still using AppEngine, and has problems scaling the database. But this future is not here yet and who knows if it'd ever happen.

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 0.0% when pulling 499636693c4048781eecbba89fe9f68da68272e1 on forum_administration into d275eb846fb36aa389069c086adf3e43291c643b on master.