search

ScPo-CompEcon / CourseMatch-archive.jl

CourseMatch implementation at ScPo
Other
1 stars 12 forks source link

Demand Function updated #17

Closed Gegas2231 closed 6 years ago

Gegas2231 commented 6 years ago
floswald commented 6 years ago

looks good, thanks. wht you mean with The test scenario is not working? can we come up with an example that is runnable? would be good...

Gegas2231 commented 6 years ago

With the test scenario I meant the example. It is working now, it still needs a little of luck to get a good draw, but with good data, the algorithm is working and all the constraints are good.

floswald commented 6 years ago

hi @Gegas2231 i decided to merge julies version from #14 - now on master. can you please give a look at CourseMatch.jl/src/demand.jl and see if there is anything that needs to be ported over from your PR to that version or if that does all the things you want it to do already? thanks!

floswald commented 6 years ago

looking good! let me know when you are done (or if you decide to not work any more on this!) thanks

Gegas2231 commented 6 years ago

The version is pretty much definitive. i will break down a couple of constraints to match the Students struct, but i have an exam tomorrow so i will probably work on this tomorrow afternoon.

Gegas2231 commented 6 years ago

Hi Florian, I was completely absorbed by thesis so I could not make the quick fixes I said were left. The function now looks like what a final version of the function will be and matches a more complete version of the structure 'Student'.

I do not know if this version should be merged into the master yet because first, the student.jl needs to be able to read all the information and properly categorize it, the current version of it is an early stage. However this is my final version of demand function and could be useful later if the project continues

floswald commented 6 years ago

manually merged and changed. latest version on branch agg_dem.