search

ScPoEcon / ScPoApps

Interactive apps for our econometrics course
Other
3 stars 4 forks source link

Check for the Ability bias App #8

Closed dxy99999 closed 4 years ago

dxy99999 commented 4 years ago

Thank you for your help!!!

floswald commented 4 years ago

commented on the issue! almost there!

floswald commented 4 years ago

this is very good. final thing: we need to add a test for this app to make sure it's working as expected on all client machines. we do this via the shinytest package. we basically record a series of snapshots for this app, and a remote server checks whether what he sees corresponds to our snapshot - on mac, windows and linux. I'll merge your PR now and add the test in a separate PR, so you can see what needs to be done for that (for future apps! :wink:)