.Rbuildignore is removing tutorials

schloerke commented 5 years ago

output from installation:

   Removed empty directory ‘ScPoEconometrics/inst/tutorials/chapter2’
   Removed empty directory ‘ScPoEconometrics/inst/tutorials/correlation’
   Removed empty directory ‘ScPoEconometrics/inst/tutorials/lm-example’
   Removed empty directory ‘ScPoEconometrics/inst/tutorials/non-normal’
   Removed empty directory ‘ScPoEconometrics/inst/tutorials/rescaling’
   Removed empty directory ‘ScPoEconometrics/inst/tutorials/trade’
   Removed empty directory ‘ScPoEconometrics/inst/tutorials’

https://github.com/ScPoEcon/ScPoEconometrics/blob/ac77c17eb45e76c97ea8dd8902cc4fc5c34a0cc1/.Rbuildignore#L8

Maybe change to ^\d\d-.*\.Rmd to only ignore the top level Rmd files?

floswald commented 5 years ago

hmm, that's probably a good idea :-)

i never actually encountered this problem. I only build the package on travis where i want to run the unit tests - so for students installation via install_github should preserve those files (at least that's what I though - anyway I have never seen that output before).

but that's a good suggestion!

schloerke commented 5 years ago

I'm chasing down the bug in https://github.com/rstudio/shiny/issues/2307. (It's in rmarkdown.)

Correct. After installing it, I got the output:

ScPoEconometrics::runTutorial("chapter2")
#> Error: Please run `runTutorial()` with a valid tutorial as an argument.
#> Valid Tutorials are: ''

floswald commented 5 years ago

that's an issue. so it seems really that those files are lost. can you just check

list.files(system.file("shinys", package = "ScPoEconometrics"),full.names=TRUE)
list.files(system.file("tutorials", package = "ScPoEconometrics"),full.names=TRUE)

it's strange because for me it's working (after removal of the packge and new install...). what i'm doing here with the Rbuildignore may be a bit risky.

floswald commented 5 years ago

did the .Rbuildignore change anything for you?

schloerke commented 5 years ago

Yup. The tutorials are there now.

❯❯ devtools::install_github("ScPoEcon/ScPoEconometrics")
Downloading GitHub repo ScPoEcon/ScPoEconometrics@master
Skipping 1 packages ahead of CRAN: rmarkdown
   checking for file ‘/private/var/folders/0k/bxg5lhr92sq74mb1d446ql540000gp/T/RtmpsJtKwP/remotes172744c55143f/ScPoEcon-ScPoEconometrics✔  checking for file ‘/private/var/folders/0k/bxg5lhr92sq74mb1d446ql540000gp/T/RtmpsJtKwP/remotes172744c55143f/ScPoEcon-ScPoEconometrics-a9b19c4/DESCRIPTION’
─  preparing ‘ScPoEconometrics’:
✔  checking DESCRIPTION meta-information ...
─  checking for LF line-endings in source and make files and shell scripts
─  checking for empty or unneeded directories
   Removed empty directory ‘ScPoEconometrics/.github’
   Removed empty directory ‘ScPoEconometrics/data’
   Removed empty directory ‘ScPoEconometrics/images’
   Removed empty directory ‘ScPoEconometrics/teachers’
─  building ‘ScPoEconometrics_0.2.1.tar.gz’

* installing *source* package ‘ScPoEconometrics’ ...
** R
** inst
** byte-compile and prepare package for lazy loading
** help
*** installing help indices
** building package indices
** testing if installed package can be loaded
* DONE (ScPoEconometrics)

✔ 143.3 MiB (6s) 
❯❯ library(ScPoEconometrics)

✔ 231.1 MiB (1s) 
❯❯ runTutorial("chapter2")

processing file: chapter2.Rmd
  |.                                                                |   1%
  ordinary text without R code

  |..                                                               |   3%
..........................................................(much more output)

opmc2 commented 5 years ago

This worked for me too.

ScPoEcon / ScPoEconometrics

.Rbuildignore is removing tutorials #110