search

ScaCap / action-ktlint

Run Ktlint with reviewdog
Apache License 2.0
84 stars 29 forks source link

Add relative flag support #9

Closed DVDAndroid closed 4 years ago

DVDAndroid commented 4 years ago

Added relative flag support --relative to support relative paths instead of absolute ones.

The default value is false, but in my opinion, it should be true since I don't want to see absolute path (ex: /home/github/actions/...) in my Github Actions logs

DVDAndroid commented 4 years ago

@renatoabreu11 sorry for bothering you, can you take a look at this? There are many PRs open

renatoabreu11 commented 4 years ago

@renatoabreu11 sorry for bothering you, can you take a look at this? There are many PRs open

Hey @DVDAndroid. No problem at all, I will take a look! Sorry to take so long, I didn't receive a notification

DVDAndroid commented 4 years ago

Will the default value of relative change? I think people don't want to see internal Github Actions path (ex: /home/github/actions) in logs

renatoabreu11 commented 4 years ago

Will the default value of relative change? I think people don't want to see internal Github Actions path (ex: /home/github/actions) in logs

Yes, I agree with you. I will make the change as well 👍