search

ScaCap / action-surefire-report

Reports surefire test results as GitHub Pull Request Check
Apache License 2.0
88 stars 59 forks source link

Update to Node.js 20 #202

Closed JPowell-AA closed 8 months ago

JPowell-AA commented 9 months ago

Getting build warning: "Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: scacap/action-surefire-report@v1."

For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

ghaiszaher commented 9 months ago

Thanks @JPowell-AA. It is planned to upgrade to Node 20 soon with https://github.com/ScaCap/action-surefire-report/pull/185 - as soon as https://github.com/nock/nock/issues/2397 is solved which appears to be soon.

I'll wait for a few days until the fix is released, if it takes too long I'll disable the tests and merge the PR.

mbazos commented 8 months ago

Hey @ghaiszaher update on this? Should you maybe disable the tests and merge the PR?

ghaiszaher commented 8 months ago

@mbazos I am raising the pull request now, hopefully released by tomorrow

ghaiszaher commented 8 months ago

Upgrade to Node 20 was released, please make sure to use tags v1.8.0 or v1

mbazos commented 8 months ago

Thanks @ghaiszaher!