search

ScaCap / spring-auto-restdocs

Spring Auto REST Docs is an extension to Spring REST Docs
https://scacap.github.io/spring-auto-restdocs/
Apache License 2.0
311 stars 86 forks source link

Upgrade most dependencies and migrate several tests to AssertJ #419

Closed fbenz closed 4 years ago

fbenz commented 4 years ago

org.junit.Assert.assertThat was deprecated for our use case with Hamcrest matchers. Thus, I either replaced it by org.hamcrest.MatcherAssert.assertThat or directly migrated the test to AssertJ.

fbenz commented 4 years ago

The build is green: https://travis-ci.org/github/ScaCap/spring-auto-restdocs/builds/729441306

LEQADA commented 4 years ago

Why don't we see Travis results in PRs anymore?

Perhaps because of this?

https://github.com/ScaCap/spring-auto-restdocs/blob/0afad4983aa4ccff5e32a9788a1799bbd47f110c/.travis.yml#L40-L42

fbenz commented 4 years ago

Why don't we see Travis results in PRs anymore?

Perhaps because of this?

https://github.com/ScaCap/spring-auto-restdocs/blob/0afad4983aa4ccff5e32a9788a1799bbd47f110c/.travis.yml#L40-L42

I don't think so. Travis is actually triggered but it's not reported here. So something in the communication between Travis CI and GitHub is broken.