search

ScaCap / spring-auto-restdocs

Spring Auto REST Docs is an extension to Spring REST Docs
https://scacap.github.io/spring-auto-restdocs/
Apache License 2.0
310 stars 86 forks source link

#448: added failOnUndocumentedFields method for JacksonModellAttribut… #456

Closed jmisur closed 2 years ago

jmisur commented 2 years ago

Fixes #448 #449

jmisur commented 2 years ago

@fbenz I removed the default false param from tests and used the creator method for true tests.

mustaphazorgati commented 2 years ago

I just had a look at this. It seems to be fine. Just one thought: Should we create a test where not all documented fields are present and assert that an exception is thrown (because there are some fields which are not documented)?

jmisur commented 2 years ago

I just had a look at this. It seems to be fine. Just one thought: Should we create a test where not all documented fields are present and assert that an exception is thrown (because there are some fields which are not documented)?

There are 2 tests already failOnUndocumentedParameters and failOnUndocumentedFields.

jmisur commented 2 years ago

🏓 @fbenz