search

Scaffold-Stark / speedrunstark

SpeedRunStark challenges (Powered by Scaffold-Stark)
https://www.speedrunstark.com
18 stars 18 forks source link

Wrong Eth Balance Display #137

Closed tekkac closed 2 months ago

tekkac commented 2 months ago

Issue Overview

The Eth balance display is wrong because of incorrect padding.

Proposed Solutions or Ideas

Correct the off-by-one error in the balance computation.

screen2 screen1

Nadai2010 commented 2 months ago

Hi, thanks for the contribution.

What is the process to detect the issue? I attach tests in Braavos and Argent, sorry for the quality of the images, but if I took a screenshot the values ​​in the wallets looked blurry.

1(1)

2(3)

tekkac commented 2 months ago

You should try on the speedrunstark website. The issue doesn't occur in the original scaffold-stark repo as the hook is different.

Nadai2010 commented 2 months ago

Ah perfect, thank you very much,🫡