Scaffold-Stark / speedrunstark

SpeedRunStark challenges (Powered by Scaffold-Stark)
https://www.speedrunstark.com
18 stars 18 forks source link

chore: add retry to addIPfs and getIpfsMetadata #151

Closed ShantelPeters closed 1 month ago

ShantelPeters commented 1 month ago

Fixes #141

Types of change

Comments (optional)

By adding retry mechanisms to both the addToIPFS and getMetadataFromIPFS functions, I’ve addressed the NFT duplication issue during fast minting on Sepolia. The retries ensure multiple attempts to handle delays or interruptions, reducing the chances of Token ID 1 being duplicated due to incomplete metadata processing

metalboyrick commented 1 month ago

Hi @ShantelPeters, is this PR ready to review, feel free to request reviews if you feel ready!

ShantelPeters commented 1 month ago

Hi @ShantelPeters, is this PR ready to review, feel free to request reviews if you feel ready!

Yes it is @metalboyrick

Nadai2010 commented 1 month ago

Hi @ShantelPeters the metadata of the TokenID 1 the NFT is still being duplicate in Sepolia.

Flow:

NFT in Explorer

imagen

ShantelPeters commented 1 month ago

@metalboyrick Kindly review