Closed davidrpugh closed 7 years ago
@bherd-rb This is a substantial change to the API that I do not want to merge without discussing pros and cons with you. @EconomicSL/core-devs feel free to provide input if interested...
@bherd-rb Any feedback to this proposed change?
@davidrpugh Sorry for my late response, I'm drowning in work. That sounds good. I don't see any reason why that should be problematic in our use cases.
@bherd-rb Thanks no worries. I am making progress. Let me know when you are ready to re-engage.
This PR moves the
tick
from theTradable
trait to the various auction traits. Reasoning is that different auctions mechanisms might trade the sameTradable
but with different tick sizes.This change is significant in that it impacts the
insert
method of the various auction traits. In particular, that method now returnsTry[A]
instead ofA
. Specifically if the order has a limit price that is a multiple of the tick size, thenSuccess(A)
is returned; elseFailure
This allows users to pattern match on the response from calling the
insert
method. This will be particularly useful when we have multiple ways in which inserted an order could case a failure.