Now have support for JSON representation of fills.

ScalABM / auctions

A functional API for auction simulations

Apache License 2.0

13 stars 1 forks source link

Now have support for JSON representation of fills. #94

Closed davidrpugh closed 7 years ago

davidrpugh commented 7 years ago

Related to issue #91 I have gone ahead and implemented logic that allows Fill instances to be converted to JSON representation. This allows client code to more efficiently store simulation output for further processing in Python/R etc.

Would be keen to have feedback on the use of JSON for this task. Would it be useful to be able to create Order instances from JSON inputs? If so I can implement the logic for this as well.

@phelps-sg, @bherd-rb, @ibillett, @EconomicSL/core-devs thoughts?

davidrpugh commented 7 years ago

I am going to go ahead and merge this PR because it doesn't break the API and provides need functionality for getting simulation demos up and running. We can continue the discussion about protocol buffers on #95 thread.