search

ScalaConsultants / reactive-rabbit

Reactive Streams driver for AMQP protocol. Powered by RabbitMQ library.
Apache License 2.0
184 stars 40 forks source link

Reorganized scaladoc for ConnectionSettings + README #27

Closed LGLO closed 8 years ago

LGLO commented 8 years ago

I've moved scaladoc string so generated documentation contains these comments. This if my first part for #24

LGLO commented 8 years ago

These JDK7 builds have failed last few times also.

mkiedys commented 8 years ago

These JDK7 builds have failed last few times also.

Bug in JDK6/7: https://github.com/travis-ci/travis-ci/issues/5227

mkiedys commented 8 years ago

@LGLO Why you merged this pull request?

mkiedys commented 8 years ago

Reverted.

mkiedys commented 8 years ago

Rules:

1) nothing goes to master without my approval 2) no merges in general - only rebase with linear history 3) small change and many commits: squash first 4) follow same git commit message style

LGLO commented 8 years ago

Is it possible we talk via sth more private and instant than github comments? My email: lech.glowiak@scalac.io or skype: lech.glowiak or twitter @LechGlowiak ?

2016-01-11 15:44 GMT+01:00 Michał Kiędyś notifications@github.com:

Rules:

1) nothing goes to master without my approval 2) no merges in general - only rebase with linear history 3) small change and many commits: squash first 4) follow same git commit message style

— Reply to this email directly or view it on GitHub https://github.com/ScalaConsultants/reactive-rabbit/pull/27#issuecomment-170574319 .