Don't close subscriber if channel is recoverable.

ScalaConsultants / reactive-rabbit

Reactive Streams driver for AMQP protocol. Powered by RabbitMQ library.

Apache License 2.0

184 stars 40 forks source link

Don't close subscriber if channel is recoverable. #64

Open mkiedys opened 7 years ago

mkiedys commented 7 years ago

/cc @guizmaii @yspotts

Rebased. Can you guys verify if this works? I'll do some more testing tomorrow.

mkiedys commented 7 years ago

/cc @guizmaii @yspotts

Rebased. Can you guys verify if this works? I'll do some more testing tomorrow. It also fails to compile in Scala 2.12. Should be easy to fix.

yspotts commented 7 years ago

@mkiedys thanks so much for the quick response!

I have tested this locally and it does in fact address the issue. We are hoping to push to production later today or tomorrow and I'll be able to confirm at that point.

Again, thanks for the great library!

yspotts commented 7 years ago

@mkiedys I can confirm it has fixed our issue. We have a brief connection drop every night, and the released version of reactive-rabbit causes our app to discontinue handling messages. This PR enables our app to continue handling messages after the dropped connection. So +1 for merging this PR.