QueueSubscription does not protect against concurrent delivery

ScalaConsultants / reactive-rabbit

Reactive Streams driver for AMQP protocol. Powered by RabbitMQ library.

Apache License 2.0

184 stars 40 forks source link

QueueSubscription does not protect against concurrent delivery #7

Closed rkuhn closed 8 years ago

rkuhn commented 9 years ago

In particular Future(buffered.foreach(deliver)) can run multiple times in parallel if requests are made in rapid succession. This can also lead to out-of-order delivery of items.

mkiedys commented 9 years ago

@rkuhn Thanks for doing review. You are absolutely right. I'm working on fix.