search

ScalaConsultants / reactive-rabbit

Reactive Streams driver for AMQP protocol. Powered by RabbitMQ library.
Apache License 2.0
184 stars 40 forks source link

onError may be executed more than once #9

Closed mkiedys closed 9 years ago

mkiedys commented 9 years ago

Since code that handles demand overflow lives inside ScalaSTM atomic block it may be executed more than once.

Overflow handler: https://github.com/ScalaConsultants/reactive-rabbit/blob/dc2a055e3f7bf8e4def53538d25e1a054ab6f5e3/src/main/scala/io/scalac/amqp/impl/QueueSubscription.scala#L71-L76

mkiedys commented 9 years ago

This is perfectly fine.