search

Scalable-Key-Value / code

Source code of the Scalable Key/Value Store (SKV)
Eclipse Public License 1.0
5 stars 9 forks source link

fix memory allocation issue #2

Closed lasch closed 10 years ago

lasch commented 10 years ago

I guess, there's not much to discuss for this one. Just a plain bug fix to solve an issue in the cursor command.

lasch commented 10 years ago

ok. I didn't expect that an additional push to my fork will add the commit to the existing pull request - learned something new today ;-) I guess, now there's something to discuss - I added the installation of files and a default destination /opt/SKV - that matches the behaviour of the original rpm of the previous versions.

lasch commented 10 years ago

according to your suggestion, it's now using common_library/application to configure the build and install. However, if there's a way to control how especially the include files are included, I'd be interested. Currently, files keep their relative path and get added the project name. For example, this creates an install path of /include/skv// - this definitely needs some review/refactoring. The target should probably be something like /include/ instead. So either the origin or the destination need to be adjusted.

lasch commented 10 years ago

Since Stefan's changes to cmake likely superseed the few changes in this pull request, I did a cherry-pick of the memory allocation fix. I will abandon the remaining changes.