replaced target_compile_definitions() with set command to work with ...

Scalable-Key-Value / code

Source code of the Scalable Key/Value Store (SKV)

Eclipse Public License 1.0

5 stars 9 forks source link

replaced target_compile_definitions() with set command to work with ... #5

Closed lasch closed 10 years ago

lasch commented 10 years ago

...cmake version 2.8.8

The target_compile_definitions was introduced after cmake 2.8.8. I don't think, we should require this just because of one line in CMakeLists.txt. @eile do you think that's reasonable?

eile commented 10 years ago

We still have 2.8.6 in use. I'll check what we do in other projects.

lasch commented 10 years ago

Any news on this? Otherwise, I'll just merge...

lasch commented 10 years ago

migrated this fix into mainline. We can revert later if needed, but at this time it's more important to allow people to build with cmake 2.8 versions before 2.8.11.