ScalablyTyped / SlinkyDemos

MIT License
29 stars 8 forks source link

Correct i18next errors #26

Closed mcallisto closed 4 years ago

mcallisto commented 4 years ago

The current demo was not fully working, throwing the following console errors:

Now it is correct, even if I have not been able to trace the original demo, if there was one, so I am not totally sure about what was the intended result.

mcallisto commented 4 years ago

I went back to status Draft.

I wanted to make it more meaningful, but I am struggling to get Plurals, Context and Interpolation working...

mcallisto commented 4 years ago

https://github.com/ScalablyTyped/SlinkyDemos/pull/26/commits/32bbe73900a862d62859b5cfdbc82df65d9c4615 otherwise: Warning: render(): Rendering components directly into document.body is discouraged, since its children are often manipulated by third-party scripts and browser extensions. This may lead to subtle reconciliation issues. Try rendering into a container element created for your app. react-dom.development.js:88:30

mcallisto commented 4 years ago

Cool, thanks!

Merge when you're happy with it :)

Thank you! Merging now, it is a small step forward anyway.

I will try opening an issue for remaining unsolved use cases.