search

ScalablyTyped / SlinkyDemos

MIT License
29 stars 8 forks source link

Without slinky.web.html.placeholder #5

Closed mcallisto closed 4 years ago

oyvindberg commented 4 years ago

Nice! If you feel like it it would be even better to remove the dependency on slinky-web for the react-native project. Otherwise LGTM

mcallisto commented 4 years ago

If you feel like it it would be even better to remove the dependency on slinky-web for the react-native project.

Ok, I tried

oyvindberg commented 4 years ago

That looks like a good way of doing it. It's currently missing the scalajs-dom dependency for slinky native, and slinky native is declared two times for react-native. If you can fix up that we're good here :)

mcallisto commented 4 years ago

If you can fix up that we're good here :)

Done!

oyvindberg commented 4 years ago

Thanks!