More Item Filters

[Rijam]

What are the changes?

I added more item filters. I also changed the tModLoader filter icon from the wrench to a tModLoader logo.

New filters:

• Consumables: Any item that is consumable and doesn't place a tile
• Tools: Any item that has pickaxe power, axe power, or hammer power
• Ammo: Any item that can be used as ammo
• Expert: Any item that is Expert Mode exclusive
• Master: Any item that is Master Mode exclusive
• Vanity: Any item that is a vanity item
• Critters: Any item that creates an NPC
• Mounts: Any item that is a mount
• Pets: Any item that is a pet or light pet
• Hooks: Any item that is a grappling hook
• Material: Any item that is a material

New filters screenshot: New tModLoader icon:

Are there any alternate designs?

I considered a filter of boss bags, but I felt like that was easily covered by the Expert filter. I also considered a grab bag filter using ItemID.Sets.OpenableBag[], but I found that modded grab bags aren't in that set automatically.

Here are two alternate designs for the tModLoader icon:

Alternate designs:

Obviously, some of the sprites for the filter icons had more effort put into them over others. [Anyone] feel free to resprite any of them.

[ScalarVector1]

I'm concerned a few of these have very marginal use cases or could be collapsed together.

Pick/Axe/Hammer, why not unify under 'tool'? Numerous items are duplicated across categories due to being hamaxes/pick-axe's in vanilla already, and especially in mods. Seperation here feels a bit uneeded.

Expert/Master, I dont see any reasonable usecase for filtering on this, especially when the categories are very small.

Fishing feels a bit like numerous things smashed together. The only real unifying line here is purely thematic, this seems like a poor candidate for a practical filter

Create NPC: Why not call this something like 'critters'? Are there notable other types of items that create NPCs?

Wings: I see no reason to seperate this from the accessory filter, they only differentiate thematically

Unresearched: Concerned on low practicality. Why would a user be concerned with what items they havent researched from the cheat mod menu that lets you spawn any item anyways?

[Rijam]

Most of the filters are there to match Cheat Sheet/HERO's Mod/Recipe Browser's filters.

Pick/Axe/Hammer: I like them separate but ok I can combine them.

Expert/Master: They are items exclusive to certain difficulty modes so I feel like they should have their own filters.

Fishing: ok, I'll remove it.

Create NPC: In vanilla they are all critters, but mods might many items that spawn NPCs that aren't critters. Fargo's Mutant Mod's captured Town NPCs aren't critters but would still fall under the Create NPC filter.

Wings: ok, I'll remove it.

Unresearched: I thought it was cool, but ok I'll remove it.

Edit: Might have to close this PR because I committed to the 1.4.4 branch instead of making a new branch. The new commits aren't showing up in this PR even though they do if you click my 1.4.4 branch.

[Setnour6]

There aren't any more commits here after the response comment. Rijam, are you still working on it?