Draft: this requires #187 to be merged first - only last commit in refactor-NicType branch is relevant.
The Nic._handle_nic_type method implemented conversion of NIC type from hypercore to ansible.
But in code it was used also to "convert" from ansible to ansible - whis was wrong.
Unittest did pass because we had also wrong unittest data - mock data pretended HyperCore returns "virtio", but in reality "VIRTIO" is returned.
This is now changed, unittest mock data is fixed, and Nic._handle_nic_type is replaced with NicType.hypercore_to_ansible.
Draft: this requires #187 to be merged first - only last commit in refactor-NicType branch is relevant.
The
Nic._handle_nic_typemethod implemented conversion of NIC type from hypercore to ansible. But in code it was used also to "convert" from ansible to ansible - whis was wrong. Unittest did pass because we had also wrong unittest data - mock data pretended HyperCore returns "virtio", but in reality "VIRTIO" is returned.This is now changed, unittest mock data is fixed, and
Nic._handle_nic_typeis replaced withNicType.hypercore_to_ansible.