search

ScaleComputing / HyperCoreAnsibleCollection

Official Ansible collection for Scale Computing SC//HyperCore (HC3) v1 API
GNU General Public License v3.0
12 stars 8 forks source link

Vm snapshot #217

Closed domendobnikar closed 1 year ago

domendobnikar commented 1 year ago

As a user I would like to be able to create, list, delete and clone from VM level snapshots using “hypercore” collection. Cloning is done in a separate PR. https://github.com/ScaleComputing/HyperCoreAnsibleCollection/pull/219

domendobnikar commented 1 year ago

Integration tests: https://github.com/ScaleComputing/HyperCoreAnsibleCollection/actions/runs/4829318439

domendobnikar commented 1 year ago

It's not being replaced anymore. I moved the calculate_datelogic to utils, since it makes more sense to calculate it once during from_ansible when making an object and have the calculated value stored within the object instead of dictionary. So now the module.params is not being altered at all, the calculated time stamp value is stored inside the VMsnapshot object instead.

justinc1 commented 1 year ago

Sorry @domendobnikar I complained a second time about "do not replace value of module.params["retain_for"]" - I guess I was looking at old code. my bad :/