ScaleComputing / HyperCoreAnsibleCollection

Official Ansible collection for Scale Computing SC//HyperCore (HC3) v1 API
GNU General Public License v3.0
12 stars 8 forks source link

Fix version_update_single_node to send shutdown request multiple times. #226

Closed anazobec closed 1 year ago

anazobec commented 1 year ago

Some VMs didn't want to receive a shutdown request, so version_update_single_node was updated so that the shutdown request is sent multiple times - in a loop.

justinc1 commented 1 year ago

For some reason Windows VMs sometimes ignore ACPI shutdown. Current PR would:

It would be better if send shutdown is moved into wait on VM shutdown loop. So if some VM does not shutdown, then we retry shutdown. That is inside shutdown_vms.yml, move taks name: Shutdown running VMs into:

# Wait up to 300 sec (30*10)
- name: Wait until VMs shutdown
  include_tasks: wait_vm_shutdown.yml
  loop: "{{ range(0, 30) | list }}"
  when: version_update_all_vms_stopped | default(true)

Would that work?