search

ScaleComputing / HyperCoreAnsibleCollection

Official Ansible collection for Scale Computing SC//HyperCore (HC3) v1 API
GNU General Public License v3.0
12 stars 8 forks source link

Question about a test check_mode.yml for vm_params #275

Closed kbothwell closed 7 months ago

kbothwell commented 10 months ago

Describe the bug

Not a bug but a question. This test appears to be checking whether or not check_mode is functioning for the the vm_params module, but that module does not support check_mode. Will check_mode be supported for this module in the future?

justinc1 commented 10 months ago

Check mode will likely not be implemented. Initially (before first release) the vm_params module did have check mode, and that's why this test file is still there.

In check mode the module needs to realistically simulate what would happen. Ideally the returned output is usable in next ansible task. If task using vm_params will power on a VM, then in check mode the returned value will be like before power_state=off, after power state=on. That does work.

But if vm module needs to add a disk to VM, what disk UUID should be returned? Any later task using the returned UUID will notice there is no such disk.

justinc1 commented 10 months ago

@kbothwell Does this answer the question? Can we close the issue?

kbothwell commented 7 months ago

Yes, my apologies.