ScaleComputing / HyperCoreAnsibleCollection

Official Ansible collection for Scale Computing SC//HyperCore (HC3) v1 API
GNU General Public License v3.0
12 stars 8 forks source link

:lady_beetle: Bug: cluster_config role stops if NTP can't be validated #321

Open ddemlow opened 6 days ago

ddemlow commented 6 days ago

Describe the bug

A clear and concise description of what the bug is.

To Reproduce Steps to reproduce the behavior: cluster_config role will stop setting other values if time_server: fails to set

in this case because of invalid dns (expected for this "staging" environment) preventing us from resolving IP

TASK [scale_computing.hypercore.cluster_config : Set time server] **** Wednesday 26 June 2024 12:22:50 -0400 (0:00:00.017) 0:00:02.597 **** fatal: [staging4]: FAILED! => {"changed": false, "msg": "Unexpected response - 400 b'{\"error\":\"pool.ntp.org is not a valid NTP server\"}'"}

Expected behavior

A clear and concise description of what you expected to happen.

I think it would be expected to continue setting other parameters

Screenshots

If applicable, add screenshots to help explain your problem.

System Info (please complete the following information):

Additional context

Add any other context about the problem here.

justinc1 commented 5 days ago

Makes sense. Whole playbook/role will still need to fail, but larger percent of requested changes will be applied.