search

ScaleComputing / HyperCoreAnsibleCollection

Official Ansible collection for Scale Computing SC//HyperCore (HC3) v1 API
GNU General Public License v3.0
12 stars 8 forks source link

Add support for vm machine types #40

Closed ghost closed 2 years ago

ghost commented 2 years ago

Resolves #12

Has to be merged after merging https://github.com/ScaleComputing/HyperCoreAnsibleCollection/pull/36. Suggest also reviewing it after merging https://github.com/ScaleComputing/HyperCoreAnsibleCollection/pull/36 since some rebasing has been done from https://github.com/ScaleComputing/HyperCoreAnsibleCollection/pull/36.

ghost commented 2 years ago

The PR is ready for the review :)

justinc1 commented 2 years ago

@domendobnikar One bug found in file module_utils/vm.py, line 242 if ansible_dict["cloud_init"]["user_data"] is not None - key missing, see https://gitlab.xlab.si/scale-ansible-collection/HyperCoreAnsibleCollection/-/jobs/88990. Branch 12-add-support-for-VM-machine-types at commit 99f438f7a241c5e7310d980a0b709e0bee038984.

One other integ tests also failed - https://gitlab.xlab.si/scale-ansible-collection/HyperCoreAnsibleCollection/-/jobs/88997. I retried it - see https://gitlab.xlab.si/scale-ansible-collection/HyperCoreAnsibleCollection/-/jobs/89023.

I do not know why gitlhub.com CI test didn't found it (I didn't push my last commit there yet, but this changes only one unit test).