ScaleLeap / amazon-marketplaces

A collection of Amazon Marketplace data objects.
https://npm.im/@scaleleap/amazon-marketplaces
MIT License
13 stars 11 forks source link

Incorrect country code of London region #122

Closed nguyentoanit closed 4 years ago

nguyentoanit commented 4 years ago

AmazonMarketplaceAdvertisingCountryCode enum contains GB country code. But i think it's incorrect. It should be UK.

Ref: Regional profile time zone codes

moltar commented 4 years ago

Hm, that is an interesting observation!

In MWS docs, they use GB.

That is the official ISO country code.

I'm going to open an issue with Amazon Advertising team in Jira.

Is this UK value used anywhere as input or output from the API? Or is it just part of the docs?

Thanks

moltar commented 4 years ago

Opened a Jira issue ADAPI-4698

nguyentoanit commented 4 years ago

It is output from Amazon Advertising API when i get Profile list. currencyCode, timezone, marketplaceStringId are still fine. But countryCode is UK not GB

{
  "profileId": 123456789,
  "countryCode": "UK",
  "currencyCode": "GBP",
  "dailyBudget": 0.0,
  "timezone": "Europe/London",
  "accountInfo": {
    "marketplaceStringId": "A1F83G8C2ARO7P",
    "id": "XXXXXX",
    "type": "seller"
  }
}
github-actions[bot] commented 4 years ago

:tada: This issue has been resolved in version 3.0.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: