ScaleLeap / amazon-marketplaces

A collection of Amazon Marketplace data objects.
https://npm.im/@scaleleap/amazon-marketplaces
MIT License
13 stars 11 forks source link

Migration from 17.3.0 to 18.0.0 - Cannot find module '@scaleleap/amazon-marketplaces' or its corresponding type declarations #634

Closed xhuberdeau closed 4 months ago

xhuberdeau commented 4 months ago

Hello,

Thanks for this repository!

I'm trying to migrate this dependency from 17.3.0 to 18.0.0 but typescript shows me an error: image.

I digged a bit hoping this might help: the difference I see in the node_modules between 17.3.0 and 18.0.0 is that now, the lib files are not directly in the lib folder but in a src subfolder. So the types property in the package.json seems wrong as it's pointing to a non-existing file (it should be lib/src/index.d.ts instead of lib/index.d.ts)

Version 17.3.0

image

Version 18.0.0

image

Tell me if you need more information :slightly_smiling_face:

github-actions[bot] commented 4 months ago

:tada: This issue has been resolved in version 18.0.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

nguyentoanit commented 4 months ago

@xhuberdeau: This issue should be addressed in v18.0.1. 🚀

xhuberdeau commented 4 months ago

@xhuberdeau: This issue should be addressed in v18.0.1. 🚀

Wow, thanks for the quick fix :tada: