search

ScaleLeap / amazon-mws-api-sdk

A fully typed TypeScript and Node.js Amazon MWS API Unofficial SDK
https://npm.im/@scaleleap/amazon-mws-api-sdk
MIT License
20 stars 12 forks source link

fix(orders): parse `ShippingAddress` as string #367

Closed Roman991 closed 3 years ago

Roman991 commented 3 years ago

part2 or https://github.com/ScaleLeap/amazon-mws-api-sdk/issues/365

All properties in ShippingAddress are filled by customers and should be strings

https://docs.developer.amazonservices.com/en_US/orders-2013-09-01/Orders_Datatypes.html#Address

moltar commented 3 years ago

Great, thanks.

Can you please also add some test cases for the data itself?

Please see my previous PR where I modify the XML file and added the phone. You can just edit one of the entries too, and then replace all of the values with number-looking values.

Then run npm t -- path/to/test/file.ts -u to update the snapshots.

Thanks.

github-actions[bot] commented 3 years ago

:tada: This PR is included in version 1.9.49 :tada:

The release is available on:

Your semantic-release bot :package::rocket: