ScaleLeap / selling-partner-api-sdk

A fully typed TypeScript and Node.js SDK library for Amazon Selling Partner API
https://npm.im/@scaleleap/selling-partner-api-sdk
MIT License
68 stars 28 forks source link

Using Shipping API v2 #564

Closed Antonio0001999 closed 7 months ago

Antonio0001999 commented 2 years ago

Hello. This library is the closest I have been to make Amazon's Shipping API work, but the ShippingAPIClient class only allows to make calls to Shipping API v1, would it be possible to make it work for Shipping API v2?

Many thanks.

moltar commented 2 years ago

Could you please point to the docs for the source?

@nguyentoanit Please add this, if we are indeed missing this model.

Antonio0001999 commented 2 years ago

The Shipping API v2 I'm talking about is at https://developer-docs.amazon.com/amazon-shipping/docs/shipping-api-v2-reference

This is the docs I tried to follow, is it part of the same API or I'm confused? Any help on this would be helpful, thanks.

nguyentoanit commented 2 years ago

@Antonio0001999 : They only added them into documentation site, not model repository.

We were using models from API model's repo to generate classes automatically. Therefore, we cannot make a call to Shipping API v2 from this SDK so far.

Also, I opened an issue to ask them about this.

Antonio0001999 commented 2 years ago

Many thanks for your time. Please, let me know if you are able to add it in the future.

nguyentoanit commented 2 years ago

@moltar : Should we generate API models from external sources? Like this Shipping API v2 model?

moltar commented 2 years ago

Should we generate API models from external sources?

Let's hold off and see what they reply in the issue you created.

@Antonio0001999 Please :+1: the issue @nguyentoanit created to give it more juice 😁

optikalefx commented 1 year ago

@Antonio0001999 We implemented v2 shipping about a year ago. We also made a bunch of selling partner helpers for reports and feeds in our fork. https://github.com/whitebox-co/selling-partner-api-sdk

optikalefx commented 1 year ago

And @moltar @nguyentoanit the OpenAPI Spec is here https://github.com/whitebox-co/selling-partner-api-sdk/blob/master/models/shipping-api-model-v2/shippingV2.json

github-actions[bot] commented 7 months ago

:tada: This issue has been resolved in version 7.0.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: