search

ScalefreeCOM / datavault4dbt

Scalefree's dbt package for a Data Vault 2.0 implementation congruent to the original Data Vault 2.0 definition by Dan Linstedt including the Staging Area, DV2.0 main entities, PITs and Snapshot Tables.
https://www.scalefree.com/
Apache License 2.0
143 stars 27 forks source link

140 optionality for nh link foreign hashkeys #274

Closed filcov closed 3 weeks ago

filcov commented 1 month ago

Description

Please include a summary of the changes and the related issue and context.

Fixes #(issue) Lack of optionality for foreign keys in non-historized links

Type of change

added such feature by modifying models related to nh_links Please delete options that are not relevant.

How Has This Been Tested?

I tested the new feature by running the datavault4dbt-ci-cd branch 140-optional-FK using the dbt test action. This was done in conjunction with the branch from the automatic tests repository: optional-foreignHK-for-NHLink and the corresponding datavault4dbt branch 140-Optionality-for-NHLink-foreign-hashkeys.

Test Setup: Added two new test cases: nh_link_05 and nh_link_06 models with corresponding tests in the nh_link_tests.yml file. These new models are designed to exclude foreign keys, ensuring the functionality of the new optional foreign key feature. Steps to Reproduce: Run the dbt test action on the datavault4dbt-ci-cd branch 140-optional-FK selecting the 140-Optionality-for-NHLink-foreign-hashkeys as datavault4dbt package Verify that the tests nh_link_05 and nh_link_06 successfully validate the behavior without foreign keys. (check also other nh_links ) These steps ensure that the new optional foreign key functionality works as expected. if they don't work as expected: Clone the datavault4dbt-ci-cd branch 140-optional-FK. (to view it) Clone the automatic tests repository with the optional-foreignHK-for-NHLink branch. ( to view it) And the corresponding 140-Optionality-for-NHLink-foreign-hashkeys as datavault4dbt package and modify them as needed

Test Configuration:

Checklist:

tkirschke commented 1 month ago

Please Add Databricks & Oracle

filcov commented 4 weeks ago

@tkirschke I added the modifications to Oracle and Databricks. Then I successfully tested with datavautl4dbt-ic-cd dbt test. I guess you can run the pipeline; let me know if you need anything else :)

Please Add Databricks & Oracle

tkirschke commented 3 weeks ago

Hi @filcov ,

Just started the pipeline! Could you please already adjust the Webiste documentation regarding optionality of Foreign Hashkeys?

remoteworkflow[bot] commented 3 weeks ago

Link to workflow summary: https://github.com/ScalefreeCOM/datavault4dbt-ci-cd/actions/runs/11592407146

RESULTS for Synapse: :x: dbt-tests
:white_check_mark: dbt-macro-tests

RESULTS for Postgres: :white_check_mark: dbt-tests :white_check_mark: dbt-macro-tests

RESULTS for BigQuery: :white_check_mark: dbt-tests :white_check_mark: dbt-macro-tests

RESULTS for Redshift: :white_check_mark: dbt-tests :white_check_mark: dbt-macro-tests

RESULTS for Snowflake: :white_check_mark: dbt-tests :white_check_mark: dbt-macro-tests

RESULTS for Exasol: :x: dbt-tests :x: dbt-macro-tests

RESULTS for Fabric: :white_check_mark: dbt-tests :white_check_mark: dbt-macro-tests

RESULTS for Oracle: :white_check_mark: dbt-tests :white_check_mark: dbt-macro-tests

RESULTS for Databricks: :white_check_mark: dbt-tests :white_check_mark: dbt-macro-tests

filcov commented 2 weeks ago

Hi @filcov ,

Just started the pipeline! Could you please already adjust the Webiste documentation regarding optionality of Foreign Hashkeys?

Done!