search

ScalesCSS / scalescss

A design-free, modular collection of OOCSS patterns, framework settings, and utilities for quickly building responsive web projects
http://scalescss.github.io/scalescss/
MIT License
37 stars 15 forks source link

Update clearfix to use a mixin #60

Open yodasw16 opened 6 years ago

yodasw16 commented 6 years ago

Move the CSS for Clearfix into a mixin and then use the mixin where the CSS was before. Use the Box object as an example of where the mixin should go in the file. You will also need to update the readme so that @extend is no longer documented under "Available Classes", but instead, add it to the "Usage section".

motionsuggests commented 6 years ago

I was looking into this and based on correct import order making the pkg:clearfix a mixin would mean it has to be imported before pkg:box to work. Should I make another package called "tools" and put the clearfix mixin in there?

yodasw16 commented 6 years ago

Someone already submitted a PR for this, but I haven't had a chance to look at it. https://github.com/ScalesCSS/scalescss/pull/61