Scalified / fab

Floating Action Button Library for Android
Apache License 2.0
849 stars 164 forks source link

Lollipop elevation disable shadow #12

Closed JV-TM closed 9 years ago

JV-TM commented 9 years ago

Hello, I would like to add your FAB to "over a edge of two materials". Iam using relative layout with negative margin. And FAB shadow is shown properly. Problem is that when other views has android:elevation set, it shows over FAB and FAV is not visible. So, I add elevation (higher) to FAB. FAB is shown correctly over other view, but without shadow. Any idea what I did wrong? Or how to solve this? Thank you. fab_with_elevation fab_without_elevation

vbaidak commented 9 years ago

Hi,

In ActionButton, when you enable elevation, shadow parameter becomes disabled and thus only elevation shadow is used.

In most cases the correct way is to use shadow instead of elevation, because it is supported by API 9 and higher. I think there is an issue in your layout with overlapping components. You may send me an example of your layout and I will try to help you with it.

On the other hand, elevation must work as expected (remember that it works only on Lollipop devices). If you are testing it on Lollipop and it doesn't work, tell me and I will check this for you.

Have a nice day,

Best wishes, Shell Software Inc. On 24 Feb 2015 15:57, "Jan-Vodolan-T-Mobile" notifications@github.com wrote:

Hello, I would like to add your FAB to "over a edge of two materials". Iam using relative layout with negative margin. And FAB shadow is shown properly. Problem is that when other views has android:elevation set, it shows over FAB and FAV is not visible. So, I add elevation (higher) to FAB. FAB is shown correctly over other view, but without shadow. Any idea what I did wrong? Or how to solve this? Thank you. [image: fab_with_elevation] https://cloud.githubusercontent.com/assets/8640167/6350567/58f74eb6-bc35-11e4-84c1-c24d1f20d92e.png [image: fab_without_elevation] https://cloud.githubusercontent.com/assets/8640167/6350571/68a10898-bc35-11e4-9db7-e0f95169f607.png

— Reply to this email directly or view it on GitHub https://github.com/shell-software/fab/issues/12.

vbaidak commented 9 years ago

Hi,

The issue with non-working elevation for Lollipop devices will be fixed the nearest time

Have a nice day

vbaidak commented 9 years ago

Fixed in version 1.0.5 Please check and let me know

JV-TM commented 9 years ago

Great thanks a lot (-: tested: KitKat 4.4 OK (shadow defined by fab) Lollipop 5 OK (shadow defined by standard elevation)

vbaidak commented 9 years ago

Great!

Best wishes, Shell Software Inc. On 2 Mar 2015 11:03, "Jan-Vodolan-T-Mobile" notifications@github.com wrote:

Great thanks a lot (-: tested: KitKat 4.4 OK (shadow defined by fab) Lollipop 5 OK (shadow defined by standard elevation)

— Reply to this email directly or view it on GitHub https://github.com/shell-software/fab/issues/12#issuecomment-76677955.