search

Scalified / fab

Floating Action Button Library for Android
Apache License 2.0
848 stars 164 forks source link

Default shadow offset does conform to material design guidelines #20

Closed danhawkes closed 9 years ago

danhawkes commented 9 years ago

The light source in material design is always directly above the element, so shadows do not ordinarily have an x offset.

http://www.google.com/design/spec/what-is-material/environment.html#environment-3d-world http://www.google.com/design/spec/components/buttons.html#buttons-floating-action-button

Would you please consider changing the default x offset to zero, as the typical user likely just wants a button with the recommended style?

vbaidak commented 9 years ago

Hi danhawkes,

You're completely right

Yes, these values will be fixed and the shadow defaults will be the same as described in Material Design Guidelines

Also a responsive elevation will be added by default with the option to toggle it as user TurKurT656 suggested

All this stuff is currently under development, however it is almost completed and soon will be release (I think this weekend or the next one)

So, check for updates && have a nice day

danhawkes commented 9 years ago

Great, and thank you for your work on this library.

vbaidak commented 9 years ago

Fixed in version 1.1.0