Scalingo / go-utils

Small libraries and helpers concerning errors, logging, nsq
6 stars 2 forks source link

feat(goose): add a migration registration helper allowing to use a pgx connection instead of an sql.DB instance #908

Closed SCedricThomas closed 2 months ago

SCedricThomas commented 3 months ago

I will add a version in the README.md during the first release

Not inspired a lot about the package name, don't hesitate to ask for a change

SCedricThomas commented 3 months ago

STORY-280

SCedricThomas commented 3 months ago

I have an issue with the replace directive I am usually using to test local packages:

replace github.com/Scalingo/go-utils/postgresql => /home/cedric/go/src/github.com/Scalingo/go-utils/postgresql
go: github.com/Scalingo/swan-agent/internal/migrations imports
    github.com/Scalingo/go-utils/postgresql: module github.com/Scalingo/go-utils/postgresql@latest found (v0.0.0-00010101000000-000000000000, replaced by /home/cedric/go/src/github.com/Scalingo/go-utils/postgresql), but does not contain package github.com/Scalingo/go-utils/postgresql

I also tried for the whole go-utils package

SCedricThomas commented 3 months ago

I am not able to test my package :/ I have also tried to go get the branch :

➜  swan-agent git:(feat/STORY-280/sqlc-relations-poc) ✗ go get github.com/Scalingo/go-utils/postgresql@feat/cockroachdb/add-pgx-migration-helper
go: downloading github.com/Scalingo/go-utils v7.1.1-0.20240607130814-30d2a9fd0fb1+incompatible
➜  swan-agent git:(feat/STORY-280/sqlc-relations-poc) ✗ go mod vendor                                                                           
go: github.com/Scalingo/swan-agent/internal/migrations imports
    github.com/Scalingo/go-utils/postgresql: no required module provides package github.com/Scalingo/go-utils/postgresql; to add it:
    go get github.com/Scalingo/go-utils/postgresql
SCedricThomas commented 3 months ago

Any idea ?

SCedricThomas commented 3 months ago

I succeeded to import it :face_holding_back_tears:

SCedricThomas commented 3 months ago

I will tests it and go back to you asap