search

Scalingo / grafana-scalingo

One click deploy for Grafana on Scalingo
GNU Affero General Public License v3.0
2 stars 8 forks source link

Change version number #53

Closed lazybird closed 2 years ago

lazybird commented 2 years ago

Hey @brandon-welsch

Thanks for the recent work on updating this repo.

I'm wondering if the version number is right. After using the current master, I still have "version": "7.5.0" on /api/health.

Any idea ? Anything to do with this line here ?

https://github.com/Scalingo/grafana-scalingo/blob/b29267f2f6ccf69325e559cf5f1d13895e31f495/pkg/cmd/grafana-server/main.go#L10

Soulou commented 2 years ago

Hi @lazybird

The version problem is related how the go app is built.

Official grafana distribution is changing this at build time with custom build ags which are not compatible yet with Scalingo Golang build system.

We're trying to think of a method which would work, ourselves users of Grafana, we'd be glad seeing the right version ;-)

lazybird commented 2 years ago

Ok thanks for the message.

So we can safely conclude that we are effectively running v8.3.2 and that the display is just not right for now...

Thanks again.

Soulou commented 2 years ago

Yes exactly! But V8.3.1