[Errors] We should not try to launch the process if no war files are found.

Scalingo / java-war-buildpack

Buildpack to deploy a war package (install jvm + webapp runner)

MIT License

0 stars 1 forks source link

[Errors] We should not try to launch the process if no war files are found. #15

Open johnsudaar opened 4 years ago

johnsudaar commented 4 years ago

Currently if no war file is found, we fail with the following error message:

2020-04-13 09:49:41.625968226 +0000 UTC [web-1] Picked up JAVA_TOOL_OPTIONS: -Xmx300m -Xss512k -XX:CICompilerCount=2 -Dfile.encoding=UTF-8
2020-04-13 09:49:41.788248634 +0000 UTC [web-1] The specified path "./*.war" does not exist.
2020-04-13 09:49:41.791431613 +0000 UTC [web-1] Usage: <main class> [options]
[...] (Rest of the java help method)

We should fail with a better error message saying that no war files were found and link them to the Procfile docs.

johnsudaar commented 4 years ago

https://app.intercom.com/a/apps/w4oogu7s/inbox/inbox/all/conversations/26610512708

Frzk commented 1 year ago

@johnsudaar : Would it be OK to do the check in the bin/release script?

It feels a bit weird to me.

EtienneM commented 1 year ago

I think it should be checked earlier, in the bin/compile script

Soulou commented 1 year ago

Discussion with Françosi what has been decided:

A method to find the default war file should be created
- During bin/compile it should be called to mention which war file will be used during execution, and give a hint to modify WAR_PATH to use another one. If no .war could be found, the deployment should fail.
- During bin/release a wrapper script should be used, created in bin/start-war-app which will re-use the find method or directly start the app defined in WAR_PATH