Scan-o-Matic / scanomatic-standalone

GNU General Public License v3.0
0 stars 0 forks source link

Fix scan writing #102

Closed local-minimum closed 2 years ago

local-minimum commented 2 years ago

With this PR only analysis test remain to be repaired.

Bonus fixes so logging is better in attempt to find out where things go wrong.

local-minimum commented 2 years ago

I didn't quite get why admin now has the type str rather than bool, but all in all it looks good (better, even). I commented on a few small things you may want to look at while you're at it.

It might be that it can be both by some obscure magic but I noticed that contents from a file was read and placed on the admin field or a new admin thing was generated and that was a str... could be that it can be a bool too 🤷🏾