search

Scan-o-Matic / scanomatic-standalone

GNU General Public License v3.0
0 stars 0 forks source link

regridding ui #155

Closed BengtRydberg closed 2 years ago

BengtRydberg commented 2 years ago

This small PR deals with getting the regridding UI to show up / work on the analysis page. The screenshot below shows that this PR make it possible to enable the regridding: Screenshot from 2022-02-09 12-43-44

I first made an analysis without regridding, and here is a quality control from this:

Screenshot from 2022-02-09 14-19-17

I then made an analysis with regridding (with regridding setting as in the first figure), and the quality control looks like this:

Screenshot from 2022-02-09 14-18-13

the two figures clearly differ but do not know if this looks ok.

Resolves #153

local-minimum commented 2 years ago

Have you validated that if you move the grid on one of the plates (even though it is actually correct), that when doing the qc you can see it actually moved too?

BengtRydberg commented 2 years ago

Have you validated that if you move the grid on one of the plates (even though it is actually correct), that when doing the qc you can see it actually moved too?

No, I misunderstood how it was supposed to work, so I have to update the PR.

local-minimum commented 2 years ago

But to resolve the issue I'd like to at least know that reasonable request is sent to the backend and preferably that it worked or created a new issue if it didn't work.

BengtRydberg commented 2 years ago

But to resolve the issue I'd like to at least know that reasonable request is sent to the backend and preferably that it worked or created a new issue if it didn't work.

I have now made a regridding analysis, see figures above.

local-minimum commented 2 years ago

If you click the show grid image button you should be able to see the new grid image and that ought to have a grid offset from what it originally correctly was in accordance with your applied offset. Or at least something close to applying the requested offset as things aren't deterministic. But I think it looks good enough to close the issue for now.

BengtRydberg commented 2 years ago

If you click the show grid image button you should be able to see the new grid image and that ought to have a grid offset from what it originally correctly was in accordance with your applied offset. Or at least something close to applying the requested offset as things aren't deterministic. But I think it looks good enough to close the issue for now.

ok, here is a screenshot, the grid seems to have been shifted...

Screenshot from 2022-02-09 15-18-24