Scan-o-Matic / scanomatic-standalone

GNU General Public License v3.0
0 stars 0 forks source link

types and deprecations #91

Closed skymandr closed 2 years ago

skymandr commented 2 years ago

Resolves #42 (All four mentioned packages checked). Major fixes includes fixing deprecation of certain signal members.

In addition adds a lot of types. I think the types I have put in are mostly correct, but some of these types cause new mypy-conflicts. Fixing those conflicts would make this PR very messy, wherefore I have made no attempt to do so, however, I think having them is better than not having them, since they make finding inconsistencies easier, even if in some cases it is the types and not the code that is wrong. If you feel this has overstepped the bounds of decency, please say so, and I can make a PR with only the minor tweaks needed for #42 instead.