Scan-o-Matic / scanomatic-standalone

GNU General Public License v3.0
0 stars 0 forks source link

Issue 6 use npm #99

Closed skymandr closed 2 years ago

skymandr commented 2 years ago

In this PR the external dependencies are moved to npm (first part of #6). This includes

The build has been moved to js/somlib for both the new som.js and the old ccc.js as well as their associated build files, in order to get a simpler Docker build (and .gitignore). System tests have been updated accordingly.

The javascript code has also been updated thoroughly to conform with modern code standards, but functionally there are very few changes. Unfortunately it is not all the way to #62 being feasible. In addition a few dependencies have been updated, but the brunt of that work remains (second part of #6).

local-minimum commented 2 years ago

Errors on Compile view:

local-minimum commented 2 years ago

Errors on on Scan view:

local-minimum commented 2 years ago

Analysis Page:

local-minimum commented 2 years ago

Feature Extraction

local-minimum commented 2 years ago

QC (Can't check much since):

local-minimum commented 2 years ago

Fixtures:

skymandr commented 2 years ago
  • QC: Uncaught TypeError: som.Spinner is not a constructor

Fixed

  • Fixtures: Uncaught TypeError: som.setsharedvalue is not a function

Fixed

  • Fixtures: Uncaught TypeError: _jquery2.default(...)[0] is undefined attempting to detect markers on fixture

Not sure how to reproduce.

  • Feature extract: Erasing /root text in analysis folder causes console error

Cannot reproduce.

  • Analysis: No message on submit analysis (not chained)

Cannot reproduce (or I don't understand the problem – I get a popup and am redirected to status)

  • Experiment/Scan: Doesn't show CCC calibration, analysis page does so should not be an issue

Cannot reproduce (or I don't understand the problem – it is shown for me, it seems)

  • Compile: Not[h]ing happens on submit

Cannot reproduce (or I don't understand the problem – I get a popup)

  • Compile/General: Console has a lot of errors

I have fixed a lot of those.

  • General: CSS

Not sure it is the right solution, but I have tweaked the css. The problem is with a conflict between bootstrap etc. and our own css. Previously, not all pages imported any external css, now they do if you include the som.js or ccc.js.

These have been fixed.

The problem was this. Changing from arrow functions to named functions resolved the problem.

local-minimum commented 2 years ago

I've found what I've managed to spot, any issues remaining we'll have to deal with as separate bugs.