Scan-o-Matic / scanomatic

Scanomatic
GNU General Public License v3.0
10 stars 4 forks source link

Refactor the box displaying ccc metadata to a react component #224

Closed gdetrez closed 6 years ago

coveralls commented 6 years ago

Coverage Status

Coverage increased (+0.1%) to 34.733% when pulling f9b55098725565f9fa0155040d4ba4bc55e85e0d on gdetrez:ccc-infobox-component into 64d9dcde2ab7a42a22e361d76aaa89cc36ca2f58 on Scan-o-Matic:master.

skymandr commented 6 years ago

Perfect for tomorrow morning! ^^

On 22 November 2017 at 11:15, Grégoire Détrez notifications@github.com wrote:

@gdetrez commented on this pull request.

In scanomatic/ui_server_data/js/specs/components/CCCEditor.spec.js https://github.com/Scan-o-Matic/scanomatic/pull/224#discussion_r152519891 :

@@ -20,6 +20,16 @@ describe('', () => { onFinishUpload, };

  • it('should render a ', () => {
  • const wrapper = shallow(<CCCEditor {...props} />);

I have started using jsx for new components. Maybe do a mass renaming sometime when there's no ongoing work?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/Scan-o-Matic/scanomatic/pull/224#discussion_r152519891, or mute the thread https://github.com/notifications/unsubscribe-auth/AAV41tyZ6LPJkp-bM8yoQ1U62Yj1Bw-mks5s4_Q9gaJpZM4QmIeT .

-- Andreas Skyman, Ph.D. Data scientist

http://www.molflow.com/

Möller Data Workflow Systems AB (Molflow) Kungsgatan 56 411 08 Göteborg SWEDEN

phone: +46 (0)707 - 40 15 92

gdetrez commented 6 years ago

Probably not, both @local-minimum and me have open tasks :disappointed: