search

Scan-o-Matic / scanomatic

Scanomatic
GNU General Public License v3.0
10 stars 4 forks source link

Add integration test for analysis_effector #231

Closed gdetrez closed 6 years ago

gdetrez commented 6 years ago

The test runs analysis_effector on a project with one image that has been "compiled". The result is compared with the result produced by running the analysis through the web ui.

This also fixes two bugs that prevented analysis_effector to run.

coveralls commented 6 years ago

Coverage Status

Coverage increased (+5.9%) to 42.427% when pulling 0d8092c52a90b1ce3899566eb375c43fc0c1c766 on gdetrez:test-analysis-effector into d159bb3e11af5484af107d02c3e67c27e4c185c1 on Scan-o-Matic:master.

coveralls commented 6 years ago

Coverage Status

Coverage increased (+5.9%) to 42.425% when pulling 0d8092c52a90b1ce3899566eb375c43fc0c1c766 on gdetrez:test-analysis-effector into d159bb3e11af5484af107d02c3e67c27e4c185c1 on Scan-o-Matic:master.

gdetrez commented 6 years ago

There seems to be a few files in the analysis folder that seems not to be used. Is there a reason for including them? Some of them are quite large.

No, I guess I can remove them.

Side note, on same topic. The practice of placing the tests next to the code, in this case also makes our docker-image much larger than it needs to be. I wonder if that's something we should consider.

I'm not a huge fan of it either.

coveralls commented 6 years ago

Coverage Status

Coverage increased (+5.9%) to 42.439% when pulling 97dea1bc15b2f345b5c6cfa07314175f78390954 on gdetrez:test-analysis-effector into d159bb3e11af5484af107d02c3e67c27e4c185c1 on Scan-o-Matic:master.

coveralls commented 6 years ago

Coverage Status

Coverage increased (+5.9%) to 42.439% when pulling 97dea1bc15b2f345b5c6cfa07314175f78390954 on gdetrez:test-analysis-effector into d159bb3e11af5484af107d02c3e67c27e4c185c1 on Scan-o-Matic:master.