search

Scan-o-Matic / scanomatic

Scanomatic
GNU General Public License v3.0
10 stars 4 forks source link

Estimate all the coeffs (almost) #240

Closed local-minimum closed 6 years ago

local-minimum commented 6 years ago

Using all but x0.

local-minimum commented 6 years ago

I think the coveralls warning is not related to this PR but that since the origin of this branch coverage has gone down in general due to moving of the tests.

@skymandr I'd like you to specifically look at the maths of this pr. I think it is valid to require x0 to be 0 in the solution or else we will require colony-detection not to be greedy and include pixels surrounding the colony. And that seems like a bad thing to require.

coveralls commented 6 years ago

Coverage Status

Coverage decreased (-0.03%) to 39.96% when pulling 9527f715804ba62bcee692adaf3ed6c187508edd on poly-all-coeffs-realz into 6fdc5223eb420bda3dcf6182ff6557cd1d0a23b8 on master.

coveralls commented 6 years ago

Coverage Status

Coverage decreased (-0.02%) to 39.967% when pulling 0ce00d10761958cd9f1761665890aafa3ce35075 on poly-all-coeffs-realz into 6fdc5223eb420bda3dcf6182ff6557cd1d0a23b8 on master.

coveralls commented 6 years ago

Coverage Status

Coverage decreased (-0.01%) to 39.977% when pulling d05f6b8f41aaae2775aa76ddad4ee8ac5ea88c38 on poly-all-coeffs-realz into 6fdc5223eb420bda3dcf6182ff6557cd1d0a23b8 on master.